<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Thanks! I'll take a look. Also: Well oops. The test_AllOrNothing.py
file is now staged.<br>
<br>
On 1/4/2011 2:16 PM, <a class="moz-txt-link-abbreviated" href="mailto:don@amberfisharts.com">don@amberfisharts.com</a> wrote:
<blockquote
cite="mid:2e5e0f645584e65dc50d25cb3578820a@amberfisharts.com"
type="cite">Hey Thorsten,
<br>
<br>
I have a small patch you might want to include in your branch
before it merges.
<br>
It does three things:
<br>
* fix a typo in your new docs
<br>
* fixes a bug in the randrange unittests
<br>
* adds some more tests for randrange and shuffle
<br>
<br>
Furthermore it seems that you didn't commit the
test_AllOrNothing.py file.
<br>
<br>
Let me thank you once more for your determined and -it seems-
successful push for py3k support.
<br>
<br>
Cheers,
<br>
Lorenz
<br>
<br>
<br>
On Mon, 03 Jan 2011 22:42:32 -0500, Thorsten Behrens
<a class="moz-txt-link-rfc2396E" href="mailto:sbehrens@gmx.li"><sbehrens@gmx.li></a> wrote:
<br>
<blockquote type="cite">I've done what I will on the py3k branch.
It's been tested on 2.1, 2.2,
<br>
2.7, 3.1 and 3.2.
<br>
<br>
AllOrNothing unit tests are now in and show AllOrNothing failing
<br>
occasionally. This has always been the case. The unit test just
forces
<br>
the failure. Since I highly suspect that no-one actually uses
<br>
AllOrNothing.py - or these errors would have been detected
before now -
<br>
I am not going to tackle that particular piece further. Others
are more
<br>
than welcome to, of course!
<br>
<br>
I have updated the documentation that ships with pycrypto,
adding
<br>
comments on the (in)security of the algorithms included, such as
<br>
MD2/4/5, SHA1, ARC2, ARC4. Please do have a look. These changes
bear
<br>
verification by others. I may well have asserted that which is
not true,
<br>
or distorted a fact here and there.
<br>
<br>
I've issued a pull request. I'm happy to make further changes if
there
<br>
should be something I overlooked and that the unit tests did not
expose.
<br>
But barring that, I consider the porting effort complete. All
further
<br>
work - such as dealing with the errors in AllOrNothing.py and
<br>
random.sample() (the latter is an issue in Python 2.1 only),
dealing
<br>
with security concerns in Elgamal.py, deciding the fate of qNEW
- I'd
<br>
like to keep to trunk. I've made quite enough changes already on
this
<br>
private branch.
<br>
<br>
Yours
<br>
Thorsten
<br>
<br>
_______________________________________________
<br>
pycrypto mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:pycrypto@lists.dlitz.net">pycrypto@lists.dlitz.net</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.dlitz.net/cgi-bin/mailman/listinfo/pycrypto">http://lists.dlitz.net/cgi-bin/mailman/listinfo/pycrypto</a>
<br>
</blockquote>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
pycrypto mailing list
<a class="moz-txt-link-abbreviated" href="mailto:pycrypto@lists.dlitz.net">pycrypto@lists.dlitz.net</a>
<a class="moz-txt-link-freetext" href="http://lists.dlitz.net/cgi-bin/mailman/listinfo/pycrypto">http://lists.dlitz.net/cgi-bin/mailman/listinfo/pycrypto</a>
</pre>
</blockquote>
<br>
</body>
</html>