[pycrypto] Initial review of Thorsten's Py3k changes

Dwayne C. Litzenberger dlitz at dlitz.net
Sat Jan 29 20:31:27 CST 2011

On Sat, Jan 29, 2011 at 09:12:39PM -0500, Thorsten Behrens wrote:
>Okay, I got marching orders. Let me see that I have this right:
>- All test vectors back to 'something' instead of b('something'), and 
>change the routines that read the vectors to wrap the b() around it.

Yes, if that makes the most sense.

>- Take files and create one humongous new commit that has all changes.

No, each commit should be a distinct change (and each distinct change 
should have its own commit).  Having separate commits for the following 
makes sense:

     - Replace tabs with spaces
     - Py3K _fastmath.c support
     - Change _fastmath.c to compile with VC++
     - add MPIR support
     - Add Ron Rivest Test
     - Add unit tests for Crypto.Random.random
     - Update documentation with current state of security of hash and 
       cipher functions.
     - Update documentation with Python 3.x notes.
     - Add unit test for AllOrNothing
     - Fix AllOrNothing and random.sample()

But the following sorts of commits should be squashed into related commits:

     - Removed erroneous print statement from setup.py - it had snuck in 
       from the released 2.3 source
     - Now really staging the allornothing test. oops.

Does that make sense?

Dwayne C. Litzenberger <dlitz at dlitz.net>
  OpenPGP: 19E1 1FE8 B3CF F273 ED17  4A24 928C EC13 39C2 5CF7

More information about the pycrypto mailing list