[pycrypto] configure, PATH, and setup.py

John Palmieri jhpalmieri64 at gmail.com
Wed Apr 2 13:17:50 PDT 2014


I have a patch to suggest. Both on a linux system and an OS X system that I
have access to, if my PATH contains another script called "configure", then
pycrypto fails to configure properly, because the line "sh configure" finds
that other configure script rather than the pycrypto one. So could that
command be changed? For example:

$ git diff
diff --git a/setup.py b/setup.py
index 5269e9d..950d352 100644
--- a/setup.py
+++ b/setup.py
@@ -308,7 +308,7 @@ class PCTBuildConfigure(Command):
                 os.chmod("configure", stat.S_IRUSR | stat.S_IWUSR |
                          stat.S_IXUSR | stat.S_IRGRP | stat.S_IXGRP |
                          stat.S_IROTH | stat.S_IXOTH)
-            cmd = "sh configure"    # we use "sh" here so that it'll work
on mingw32 with standard python.org binaries
+            cmd = "sh ./configure"   # we use "sh" here so that it'll work
on mingw32 with standard python.org binaries
             if self.verbose < 1:
                 cmd += " -q"
             if os.system(cmd) != 0:

or (maybe more portable):

$ git diff
diff --git a/setup.py b/setup.py
index 5269e9d..77fb2b0 100644
--- a/setup.py
+++ b/setup.py
@@ -308,7 +308,7 @@ class PCTBuildConfigure(Command):
                 os.chmod("configure", stat.S_IRUSR | stat.S_IWUSR |
                          stat.S_IXUSR | stat.S_IRGRP | stat.S_IXGRP |
                          stat.S_IROTH | stat.S_IXOTH)
-            cmd = "sh configure"    # we use "sh" here so that it'll work
on mingw32 with standard python.org binaries
+            cmd = "sh %s" % (os.path.join(os.curdir, 'configure'))   # we
use "sh" here so that it'll work on mingw32 w
             if self.verbose < 1:
                 cmd += " -q"
             if os.system(cmd) != 0:

I have no experience with Windows, for example, so I don't know how
portable this kind of change would be.

-- 
John H. Palmieri
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.dlitz.net/pipermail/pycrypto/attachments/20140402/117d4813/attachment.html>


More information about the pycrypto mailing list